Skip to content

Conversation

@martin-mfg
Copy link
Member

  • permissions are specified under jobs -> build, there's no need to mention them at root level too
  • currently the "v1" tag still points to the same commit as "v1.0.0". I think either the readme sample should be updated to contain the new "V1.1.0" tag (notice the uppercase "V"), or the "v1" tag should be moved.
  • just FYI: In the logs there is still a warning "(node:2116) [DEP0040] DeprecationWarning: The punycode module is deprecated. Please use a userland alternative instead.". This seems to be an issue in setup-node.

@rickstaa
Copy link
Contributor

Hey @martin-mfg, thanks for the pull request will take a look. The v1 should be automatically moved by our action to the latest tag. See https://github.com/rickstaa/action-create-tag/tags for an example. For some reason the action not triggered. 🤔

@rickstaa
Copy link
Contributor

I think it was because the tag was created in the Github UI in my phone. I moved the tag. If you can update the pr to use v1 we can merge the PR. 🙏

@martin-mfg martin-mfg changed the title README sample: new version, cleanup permissions cleanup Jan 12, 2026
@rickstaa
Copy link
Contributor

Thanks again @martin-mfg. 🙏🏻

@rickstaa rickstaa merged commit 699af1e into stats-organization:main Jan 12, 2026
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants